-
Notifications
You must be signed in to change notification settings - Fork 185
Conversation
| lastBlockchainResync[coinType] = (new Date()).getTime(); | ||
| _server.save({ lastBlockchainResync }) | ||
| .done(() => { | ||
| const serverSave = _server.save({ lastBlockchainResync }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the problem was that isjs was updated and it looks like it no longer considers localhost as a valid IP, so I had to manually add that condition to the model validation.
What happens is Model.save() returns false if validation fails as opposed to the jqXhr promise if it passes validation. So handling that case here. It really shouldn't ever fail validation unless it's something weird like this and if it does, it will now have better console output than the seemingly random exception that was being triggered before.
| // If you change this, be sure to change anywhere in the GUI you may have output how | ||
| // long its unavailable. | ||
| const resyncInactiveTime = 1000 * 60 * 60 * 1; // 1 hour | ||
| const resyncInactiveTime = 1000 * 60; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the server POST comes back immediately and independent of the actual blockchain resync process, I decided to leave a 1 minute inactive time in to at least limit the chance of concurrent server side calls being fired off.
|
@rmisio looks good to me, tests out fine. Are you ready for it to merge? |
|
@jjeffryes yes, it's ready on my end. |
closes #1807