This repository was archived by the owner on Mar 28, 2023. It is now read-only.
Fix transaction ordering and enable Tor flag for the qa script#1982
Closed
amangale wants to merge 5 commits intoethereum-masterfrom
Closed
Fix transaction ordering and enable Tor flag for the qa script#1982amangale wants to merge 5 commits intoethereum-masterfrom
amangale wants to merge 5 commits intoethereum-masterfrom
Conversation
placer14
suggested changes
Feb 13, 2020
Member
There was a problem hiding this comment.
The commit needs to be signed and have a more descriptive message. The go-ethwallet changes need to be merged into their upstream repo and Godeps updated (using cd $GOPATH/src/github.com/OpenBazaar/go-ethwallet/ && git checkout master && git pull origin master && cd - && godep update github.com/OpenBazaar/go-ethwallet/...) after your changes have been merged upstream.
I also don't see any tests which validate the transaction ordering is applied correctly. A test like this would prevent the regression in the future and would be valuable. Do you have any thoughts on how you could produce such a test?
This reverts commit dcab63d.
… script and send a pending txn notification prior to txn confirmation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the reverse chronological ordering of eth txns. It also adds a tor flag to the qa script.