Skip to content

Conversation

@kevin8181
Copy link
Contributor

  • Auto-generate the list of grades for each scale using the json data
  • Change the type of GradeScale to make the grades property required
  • Reorganize src/index

The lists of grades that are manually defined in src/index do not match what's defined in the json data files. Is there a reason these are different, and would it make sense to remove these now that the grades are available on the scales directly?

@github-actions
Copy link

github-actions bot commented Aug 29, 2025

Coverage report

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected <=999999 not covered statements, but got 630

St.
Category Percentage Covered / Total
🟢 Statements
87.87% (+0.37% 🔼)
630/717
🟡 Branches 67.54% 129/191
🟢 Functions
81.25% (+1.38% 🔼)
130/160
🟢 Lines
86.91% (+0.22% 🔼)
571/657

Test suite run success

268 tests passing in 17 suites.

Report generated by 🧪jest coverage report action from 3d19165

@musoke musoke self-requested a review August 30, 2025 16:06
@musoke
Copy link
Collaborator

musoke commented Aug 30, 2025

Thank you for this - I had been wanting to make some similar simplifications!
I'll need to look at it carefully since you're making some substantial changes.

@musoke
Copy link
Collaborator

musoke commented Sep 3, 2025

Is this ready for review?

@kevin8181
Copy link
Contributor Author

yep!

@kevin8181
Copy link
Contributor Author

?

@musoke musoke merged commit 42330d2 into OpenBeta:develop Nov 3, 2025
3 checks passed
@musoke
Copy link
Collaborator

musoke commented Nov 3, 2025

Thank you for the reminder to come back to this - looks good, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants