Skip to content

Backport fix from PR #123#124

Merged
lohedges merged 2 commits intomainfrom
backport_123
Nov 9, 2023
Merged

Backport fix from PR #123#124
lohedges merged 2 commits intomainfrom
backport_123

Conversation

@lohedges
Copy link
Copy Markdown
Contributor

@lohedges lohedges commented Nov 9, 2023

This PR backports the fix from #123 into main.

  • I confirm that I have merged the latest version of main into this branch before issuing this pull request (e.g. by running git pull origin main): [y]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

@lohedges lohedges added bug Something isn't working recursion Related to work with Recursion labels Nov 9, 2023
@lohedges
Copy link
Copy Markdown
Contributor Author

lohedges commented Nov 9, 2023

Not sure if I also need to add the entry to the CHANGELOG? This is done on devel under the 2023.5.0 section. Perhaps you look at fixes from that section when creating a patch release and add them to the respective 2023.4.X section.

@chryswoods
Copy link
Copy Markdown
Contributor

Could you create a 2023.4.2 section in the changelog and add it to there? I then compare the devel changelog to the one in main when I do the next major release, and will remove anything that is duplicated from the previous patch release.

@lohedges
Copy link
Copy Markdown
Contributor Author

lohedges commented Nov 9, 2023

Yes, no problem. I just wasn't completely sure of the system since you could end up adding a section for a patch release that never happens. I guess it all gets sorted out at release time anyway, so it's good to have something to cross reference.

@lohedges
Copy link
Copy Markdown
Contributor Author

lohedges commented Nov 9, 2023

Done 👍

@lohedges lohedges merged commit 8cf9c15 into main Nov 9, 2023
@lohedges lohedges deleted the backport_123 branch November 9, 2023 09:58
lohedges added a commit that referenced this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working recursion Related to work with Recursion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants