Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the comparison of restraints loaded from a YAML config file. The code had missed a continue statement that would jump to the top of the loop after a successful restraint comparison, so it fell through to the catch-all by-value comparison, which fails for hex strings since they include metadata (e.g. a timestamp) from the time the object was serialised. The same fix is applied to the lambda_schedule comparison. The restraints comparison is also improved to explicitly check that the number of restraints is the same between configs, and to correctly handle different orderings by matching each restraint against the pool of unmatched restraints from the other config.