Add recording interface #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Totto16
commented
Mar 10, 2024
Totto16
commented
- Add own menu for recordings
- add possibility to open recordings on pc
…l, it's a function, that openssl provides, without namespace (since it's c), this breaks in that case xD - add parent for all layouts, so that most functionality is not duplicated, some things where different per layout, they were made into options for that, now every layout is focusable too - renamed IDhelper to FocusHelper, since the id part is only used ina few extra cases, where it wasn't supposed to be used - add notion of top:level for widgets, so that handlers know if the current widgets is top level, default is true, but the widgets constructors of the layouts set it to false - add nativefiledialog-extended dependency, that is used (in the future) to display "open file dialogs" to open a recording file on pc - refactor single player, to not replay replays, if the recording file parameter is set on cli - add new menu to select replays, that handles replays of three kinds: cli input, standard recording folder, and optionally folders / files supplied by dialog: WIP -
… construction - make layouts support top level to be true or false, by parametezing the FocusOptions by the is_top_level bool
… of frequently used ui components
- move focus_id from usize to u32, since thats the same everywhere, since we support both 64 bit and 32 bit OS'es and multiple compilers and cross-compilers, where size_t isn#t teh same everywhere
- fixes: reacording reader and writer have no better interfaces for teh public, - fix: scroll_layours now allow 0 widgets in it and render correctly, this was not possible due to a bug, since sdl needs created render textures to be used, in the 0 widgets case, a dummy one was created and never used, so it wasn't rendering the entire scene, which was strange, now it is an optional! - chnage fps text to use ui::Label
- remove unused headers from files (also move them from .hpp to .cpp, if they're only used in the cpp) - disable a warning detection bug on msvc
fix error in scroll layout while calculating the offset, the data type was chose incorrect, it can have a negative offset value - fix Focus fill_rect in textinput, remove th whole, so that is just the whole layout, not pretty, but better than redoing the math with the fill_rect /that is aligned and has margins)
…ossibility to create scenes, that take other arguments as input. like the replay scene the replay path - add more possibilities for the date, create class that manages it, and also pareses and formats it to string, use that to get the value for the replay component in the recording selector - fix nfd includes and implementation wrapper - refactor recording reader / writer to only have one additional information object, not one per header (THIS MAY BREAK EXISTING RECORDINGS, but was necessary 😓) - add recording chooser component -> WIP - add ne3w RequestAction EventHandleType to request action and bubble that request up, until someones handles it, in the only use case atm it is used to detect the double click / OK press on the keyboard to start a selected replay game - add get_currently_focused method for focus_layout, to get the currently focused widget - fix many bugs in the modified and improved functions / files
…ere it can be done
…the newest version when using the latest options
…/wd'; assuming '5999'' in msvc
- update nfd wrapper, to not use async / future anymore, since it's not supported to launch the new dialog in another thread than the main thread - add logic to enable / disable the event dispatcher, it is needed (atm) for the dialog - change the button callback, it returns a boolean, which than emits a request action, so that parent layouts / components can do something in response to the button press - make some huge updates to the recording chooser, but it's still WIP
Totto16
force-pushed
the
open-recordings
branch
from
8543d8f to
5212e3b
Compare
…nly in the newest release (not the default in the github runner image)
- fix some msvc issues regarding implicit casting - fix some NFD windows issues
- bubble button press correctly up - call "add_all_recordings" after getting new recordings via selection - reset the focus on clearing of the scorll_layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.