Feat: Use discord social sdk #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totto16
force-pushed
the
use_discord_social_sdk
branch
from
2166a75 to
b22ecb0
Compare
use the new social sdk, to implement the needed things this is still WIP and untested
- make a private field pseudo used in normal build, it is really used in other builds e.g. emscripten
Totto16
force-pushed
the
use_discord_social_sdk
branch
from
b22ecb0 to
ae05329
Compare
- correctly build the cpp library
|
Code Coverage SummaryResults for commit: f27dcd1 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
- after migrating to the new discord social SDk, no patchelf is needed anymore, as the SONAME is set correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discord game sdk is deprecated, use the newer social sdk instead