Skip to content
This repository was archived by the owner on Oct 19, 2019. It is now read-only.

Commit eb0a21e

Browse files
committed
Fix build errors
1 parent bbf85c4 commit eb0a21e

File tree

7 files changed

+208
-43
lines changed

7 files changed

+208
-43
lines changed

packages/source-scraper-dom-runner/lib/DomRunner.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ export interface IDomRunnerArgs<RO extends IDomRunnerOptions = IDomRunnerOptions
1414

1515
export interface IDomRunner<T> extends IRunner<T, IDomRunnerOptions, IDomRunnerArgs> { }
1616

17-
export class DomRunner<T> extends Runner<T, IDomRunnerOptions, IDomRunnerArgs> implements IDomRunner<T> {
17+
export class DomRunner<T> extends Runner<T, IDomRunnerOptions, IDomRunnerArgs>
18+
implements IDomRunner<T> {
1819
public defaultOptions: IDomRunnerOptions = {
1920
jsdomConfig: {}
2021
};

packages/source-scraper-flowplayer-runner/lib/FlowplayerRunner.ts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
import { IRunner, IRunnerArgs, Runner } from 'source-scraper-core';
2-
import {
3-
IPuppeteerRunner, IPuppeteerRunnerArgs, IPuppeteerRunnerOptions, PuppeteerRunner
4-
} from 'source-scraper-puppeteer-runner';
2+
import { IPuppeteerRunnerArgs, IPuppeteerRunnerOptions, PuppeteerRunner } from 'source-scraper-puppeteer-runner';
53

6-
import {J SHandle } from 'puppeteer';
4+
import { JSHandle } from 'puppeteer';
75

86
export interface IFlowplayerConfigSource {
97
type: string;
@@ -48,7 +46,7 @@ export interface IFlowplayerConfig {
4846

4947
export type IFlowplayerRunnerOptions = IPuppeteerRunnerOptions;
5048

51-
export interface IFlowplayerRunnerArgs extends IRunnerArgs<IFlowplayerRunnerOptions> {
49+
export interface IFlowplayerRunnerArgs extends IPuppeteerRunnerArgs, IRunnerArgs<IFlowplayerRunnerOptions> {
5250
flowplayer: JSHandle;
5351
config: IFlowplayerConfig;
5452
clip: IFlowplayerClip;
@@ -58,15 +56,14 @@ export interface IFlowplayerRunnerArgs extends IRunnerArgs<IFlowplayerRunnerOpti
5856
export interface IFlowplayerRunner<T> extends IRunner<T, IFlowplayerRunnerOptions, IFlowplayerRunnerArgs> { }
5957

6058
export class FlowplayerRunner<T> extends Runner<T, IFlowplayerRunnerOptions, IFlowplayerRunnerArgs>
61-
implements IPuppeteerRunner<T> {
59+
implements IFlowplayerRunner<T> {
6260
public defaultOptions: IFlowplayerRunnerOptions = {};
6361

6462
protected async exec(
6563
url: string,
6664
scraper: (args: IFlowplayerRunnerArgs) => Promise<T>,
6765
options: IFlowplayerRunnerOptions): Promise<T> {
68-
69-
return PuppeteerRunner.run(url, async (args: IPuppeteerRunnerArgs) => {
66+
return new PuppeteerRunner<T>().run(url, async args => {
7067
const { page } = args;
7168
const flowplayer = await page.evaluateHandle('flowplayer()');
7269
const config = await page.evaluate(player => player.conf, flowplayer);

packages/source-scraper-html-runner/lib/HtmlRunner.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ export interface IHtmlRunnerArgs extends IRunnerArgs<IHtmlRunnerOptions> {
1313

1414
export interface IHtmlRunner<T> extends IRunner<T, IHtmlRunnerOptions, IHtmlRunnerArgs> { }
1515

16-
export class Runner<T> {
16+
export class HtmlRunner<T> extends Runner<T, IHtmlRunnerOptions, IHtmlRunnerArgs>
17+
implements IHtmlRunner<T> {
1718
public defaultOptions: IHtmlRunnerOptions = {
1819
axiosConfig: {}
1920
};

packages/source-scraper-jwplayer-runner/lib/JWPlayerRunner.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ export class JWPlayerRunner<T> extends Runner<T, IJWPlayerRunnerOptions, IJWPlay
131131
url: string,
132132
scraper: (args: IJWPlayerRunnerArgs) => Promise<T>,
133133
options: IJWPlayerRunnerOptions): Promise<T> {
134-
return new PuppeteerRunner().run(url, async (...args) => {
134+
return new PuppeteerRunner<T>().run(url, async (args) => {
135135
const { page } = args;
136136
const jwplayer = await page.evaluateHandle('jwplayer()');
137137
const config = await page.evaluate(player => player.getConfig(), jwplayer);

0 commit comments

Comments
 (0)