Conversation
| && bundle config build.nokogiri --use-system-libraries \ | ||
| && bundle config git.allow_insecure true \ | ||
| && python3 -m venv /openc3/venv \ | ||
| && source /openc3/venv/bin/activate \ |
There was a problem hiding this comment.
Create the build time venv
| print(x) | ||
| # array([[ 0, 1, 2, 3, 4], | ||
| # [-99, 6, -99, 8, -99], | ||
| # [-99, 11, -99, 13, -99]]) |
There was a problem hiding this comment.
I thought this script was a good addition to the demo and it lets us ensure the Python package installation process is working
| ENV GROUP_ID=1001 | ||
| # The build time venv is at /openc3/venv and the runtime venv is at /gems/python_packages | ||
| # NOTE: This is delared as PYTHONUSERBASE: "/gems/python_packages" in compose.yaml | ||
| ENV PYTHONPATH=/openc3/venv/lib/python3.11/site-packages/:/gems/python_packages/lib/python3.11/site-packages/ |
There was a problem hiding this comment.
I was able to keep the existing PYTHONUSERBASE definition of the python packages doing this
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1604 +/- ##
==========================================
- Coverage 76.82% 76.79% -0.04%
==========================================
Files 614 614
Lines 46403 46403
Branches 827 827
==========================================
- Hits 35651 35634 -17
- Misses 10661 10677 +16
- Partials 91 92 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|




This isn't pressing, just an infrastructure improvement. Let's wait to merge until end of Oct / beginning of Nov with 5.20.0.