Skip to content

Alpine19 and Python venvs#1604

Merged
ryanmelt merged 4 commits intomainfrom
alpine19
Oct 24, 2024
Merged

Alpine19 and Python venvs#1604
ryanmelt merged 4 commits intomainfrom
alpine19

Conversation

@jmthomas
Copy link
Copy Markdown
Member

@jmthomas jmthomas commented Oct 2, 2024

This isn't pressing, just an infrastructure improvement. Let's wait to merge until end of Oct / beginning of Nov with 5.20.0.

@jmthomas jmthomas requested a review from ryanmelt October 2, 2024 22:13
Comment thread openc3-ruby/Dockerfile
&& bundle config build.nokogiri --use-system-libraries \
&& bundle config git.allow_insecure true \
&& python3 -m venv /openc3/venv \
&& source /openc3/venv/bin/activate \
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create the build time venv

print(x)
# array([[ 0, 1, 2, 3, 4],
# [-99, 6, -99, 8, -99],
# [-99, 11, -99, 13, -99]])
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this script was a good addition to the demo and it lets us ensure the Python package installation process is working

Comment thread openc3-ruby/Dockerfile
ENV GROUP_ID=1001
# The build time venv is at /openc3/venv and the runtime venv is at /gems/python_packages
# NOTE: This is delared as PYTHONUSERBASE: "/gems/python_packages" in compose.yaml
ENV PYTHONPATH=/openc3/venv/lib/python3.11/site-packages/:/gems/python_packages/lib/python3.11/site-packages/
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to keep the existing PYTHONUSERBASE definition of the python packages doing this

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.79%. Comparing base (fa39518) to head (7fb6b83).
Report is 72 commits behind head on main.

Files with missing lines Patch % Lines
openc3/lib/openc3/models/plugin_model.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1604      +/-   ##
==========================================
- Coverage   76.82%   76.79%   -0.04%     
==========================================
  Files         614      614              
  Lines       46403    46403              
  Branches      827      827              
==========================================
- Hits        35651    35634      -17     
- Misses      10661    10677      +16     
- Partials       91       92       +1     
Flag Coverage Δ
frontend 56.22% <ø> (-0.25%) ⬇️
python 84.59% <ø> (-0.03%) ⬇️
ruby-api 47.62% <ø> (ø)
ruby-backend 82.82% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas
Copy link
Copy Markdown
Member Author

jmthomas commented Oct 2, 2024

How it shows up in the Packages tab:
Screenshot 2024-10-02 at 4 16 26 PM

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 2, 2024

@ryanmelt ryanmelt merged commit 06e9234 into main Oct 24, 2024
@ryanmelt ryanmelt deleted the alpine19 branch October 24, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants