Skip to content

Add from_config to PacketConfig#1663

Merged
ryanmelt merged 3 commits intomainfrom
pc_from_config
Oct 26, 2024
Merged

Add from_config to PacketConfig#1663
ryanmelt merged 3 commits intomainfrom
pc_from_config

Conversation

@ryanmelt
Copy link
Copy Markdown
Member

Adds a helpful method to create a PacketConfig from a string.

@ryanmelt ryanmelt requested a review from jmthomas October 24, 2024 03:12
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.50%. Comparing base (06e9234) to head (74fd247).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
openc3/lib/openc3/packets/packet_config.rb 30.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1663      +/-   ##
==========================================
+ Coverage   76.43%   76.50%   +0.06%     
==========================================
  Files         618      618              
  Lines       46874    46921      +47     
  Branches      849      849              
==========================================
+ Hits        35829    35897      +68     
+ Misses      10949    10929      -20     
+ Partials       96       95       -1     
Flag Coverage Δ
frontend 56.15% <ø> (-0.04%) ⬇️
python 83.85% <ø> (-0.10%) ⬇️
ruby-api 48.82% <ø> (+1.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave a comment above the method on why you added this and how you're using it? From IRB? From Script Runner?

@ryanmelt ryanmelt merged commit e48f5fe into main Oct 26, 2024
@ryanmelt ryanmelt deleted the pc_from_config branch October 26, 2024 15:28
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants