Convert existing Script Runner dialogs to Composition API#2828
Merged
EmilyRagan merged 15 commits intomainfrom Mar 27, 2026
Merged
Convert existing Script Runner dialogs to Composition API#2828EmilyRagan merged 15 commits intomainfrom
EmilyRagan merged 15 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2828 +/- ##
==========================================
+ Coverage 78.21% 78.26% +0.04%
==========================================
Files 673 673
Lines 55239 55239
Branches 728 728
==========================================
+ Hits 43206 43233 +27
+ Misses 11955 11928 -27
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d1687ef to
8976a4c
Compare
8976a4c to
bdd1bc7
Compare
f980aab to
1c673bb
Compare
9d00429 to
3e00931
Compare
3e00931 to
8bc79f2
Compare
clayandgen
reviewed
Mar 17, 2026
...lugins/packages/openc3-vue-common/src/tools/scriptrunner/Dialogs/ScriptEnvironmentDialog.vue
Outdated
Show resolved
Hide resolved
...s-init/plugins/packages/openc3-vue-common/src/tools/scriptrunner/Dialogs/OverridesDialog.vue
Show resolved
Hide resolved
1178ddf to
3ecbccd
Compare
ryan-pratt
approved these changes
Mar 20, 2026
3ecbccd to
01804a8
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The is the beginning of the transition to Composition API, starting with Script Runner. Existing dialog components were very easy to convert. The diffs are unfortunately too great to sync up the lines, but the changes are straightforward:
props.<propName>within the script, instead ofthis.<propName><computedName>.valuewithin the script, instead ofthis.<computedValue>const<dataName>.valuewithin the script, instead ofthis.<dataName>this.createdlifecycle hook is replaced byonMountedfor some cases, immediate initialization in other cases