Skip to content

Convert existing Script Runner dialogs to Composition API#2828

Merged
EmilyRagan merged 15 commits intomainfrom
begin-composition-api-transition
Mar 27, 2026
Merged

Convert existing Script Runner dialogs to Composition API#2828
EmilyRagan merged 15 commits intomainfrom
begin-composition-api-transition

Conversation

@EmilyRagan
Copy link
Copy Markdown
Contributor

@EmilyRagan EmilyRagan commented Feb 12, 2026

The is the beginning of the transition to Composition API, starting with Script Runner. Existing dialog components were very easy to convert. The diffs are unfortunately too great to sync up the lines, but the changes are straightforward:

  • Props have the same type information as before
  • Prop values are now accessed via props.<propName> within the script, instead of this.<propName>
  • Computed values are now accessed via <computedName>.value within the script, instead of this.<computedValue>
  • Use defineModel over explicit computed with emit where appropriate
  • Data values that are mutable are defined with ref, immutable values are just const
  • Data values are accessed and updated via <dataName>.value within the script, instead of this.<dataName>
  • Methods are now accessed just by their name, without this.
  • created lifecycle hook is replaced by onMounted for some cases, immediate initialization in other cases
  • Promise chaining was updated to use async/await

@EmilyRagan EmilyRagan self-assigned this Feb 12, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.26%. Comparing base (b0213e5) to head (01804a8).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2828      +/-   ##
==========================================
+ Coverage   78.21%   78.26%   +0.04%     
==========================================
  Files         673      673              
  Lines       55239    55239              
  Branches      728      728              
==========================================
+ Hits        43206    43233      +27     
+ Misses      11955    11928      -27     
  Partials       78       78              
Flag Coverage Δ
python 79.47% <ø> (-0.01%) ⬇️
ruby-api 83.58% <ø> (+0.65%) ⬆️
ruby-backend 81.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EmilyRagan EmilyRagan force-pushed the begin-composition-api-transition branch from d1687ef to 8976a4c Compare February 12, 2026 23:26
@OpenC3 OpenC3 locked and limited conversation to collaborators Feb 13, 2026
@OpenC3 OpenC3 unlocked this conversation Feb 13, 2026
@EmilyRagan EmilyRagan marked this pull request as draft February 13, 2026 15:42
@EmilyRagan EmilyRagan force-pushed the begin-composition-api-transition branch from 8976a4c to bdd1bc7 Compare February 13, 2026 18:50
@EmilyRagan EmilyRagan force-pushed the begin-composition-api-transition branch 2 times, most recently from f980aab to 1c673bb Compare March 3, 2026 16:41
@EmilyRagan EmilyRagan force-pushed the begin-composition-api-transition branch 3 times, most recently from 9d00429 to 3e00931 Compare March 17, 2026 01:33
@EmilyRagan EmilyRagan marked this pull request as ready for review March 17, 2026 16:39
@EmilyRagan EmilyRagan force-pushed the begin-composition-api-transition branch from 3e00931 to 8bc79f2 Compare March 17, 2026 17:21
@EmilyRagan EmilyRagan force-pushed the begin-composition-api-transition branch from 1178ddf to 3ecbccd Compare March 19, 2026 19:57
@EmilyRagan EmilyRagan force-pushed the begin-composition-api-transition branch from 3ecbccd to 01804a8 Compare March 27, 2026 16:39
@sonarqubecloud
Copy link
Copy Markdown

@EmilyRagan EmilyRagan merged commit 63d0fc0 into main Mar 27, 2026
53 checks passed
@EmilyRagan EmilyRagan deleted the begin-composition-api-transition branch March 27, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants