Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3176 +/- ##
=======================================
Coverage 78.33% 78.34%
=======================================
Files 673 673
Lines 55358 55351 -7
Branches 728 728
=======================================
Hits 43366 43366
+ Misses 11914 11907 -7
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
| if keyword is not None and value is not None: | ||
| add_cmd_parameter(keyword, value, cmd_params) | ||
| else: | ||
| raise RuntimeError(f"Missing value for last command parameter: {text:s}") |
There was a problem hiding this comment.
This will raise an error in the following cases:
- keyword is defined, but value is not
- keyword is not defined, but value is (practically impossible)
- keyword is not defined and neither is value
Is this the correct set of cases to raise the error? I expect case 1 is intended to raise an error, and I think case 2 is practically impossible, but I'm less sure about case 3. I believe case 3 can be satisfied by ending the string with a comma or a command and a space ("TEST TEST with KEY VALUE," or "TEST TEST with KEY VALUE, "). Are these examples in which you would expect the "Missing value for last command parameter" error to be raised?
There was a problem hiding this comment.
Yes because commas are for separating parameters and if they add one and do not complete the next it is a syntax error
3 participants
closes #3172
Fixes 3 bugs:
tcpip_server_interface.py: index 0 was being skipped
decom_microservice.p: value of 0 reported as "disabled" in limits_change_callback
form_accessor.py: empty string form values were dropped