Skip to content

Handle command only target#455

Merged
ryanmelt merged 1 commit intomainfrom
handle_cmd_only_target
Feb 4, 2023
Merged

Handle command only target#455
ryanmelt merged 1 commit intomainfrom
handle_cmd_only_target

Conversation

@ryanmelt
Copy link
Copy Markdown
Member

@ryanmelt ryanmelt commented Feb 4, 2023

closes #449

@ryanmelt ryanmelt requested a review from jmthomas February 4, 2023 01:42
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 4, 2023

Codecov Report

Base: 74.43% // Head: 76.66% // Increases project coverage by +2.23% 🎉

Coverage data is based on head (479ba6c) compared to base (4600a58).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
+ Coverage   74.43%   76.66%   +2.23%     
==========================================
  Files         458      439      -19     
  Lines       27968    26729    -1239     
  Branches      592      592              
==========================================
- Hits        20819    20493     -326     
+ Misses       7055     6142     -913     
  Partials       94       94              
Flag Coverage Δ
ruby-api 63.13% <ø> (+12.93%) ⬆️
ruby-backend 78.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lib/openc3/microservices/interface_microservice.rb 78.03% <100.00%> (+0.05%) ⬆️
openc3-cosmos-script-runner-api/config/routes.rb
...nc3-cosmos-script-runner-api/config/environment.rb
...smos-script-runner-api/config/initializers/cors.rb
...pi/config/initializers/filter_parameter_logging.rb
...pt-runner-api/config/initializers/authorization.rb
...nner-api/app/channels/application_cable/channel.rb
...api/app/controllers/completed_script_controller.rb
...nner-api/app/controllers/application_controller.rb
...t-runner-api/app/controllers/scripts_controller.rb
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryanmelt ryanmelt merged commit 6a7f2b4 into main Feb 4, 2023
@ryanmelt ryanmelt deleted the handle_cmd_only_target branch February 4, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command Only Target Breaks Microservice

2 participants