Skip to content

Switch Traefik to HTTP endpoint for dynamic config#515

Merged
ryanmelt merged 3 commits intomainfrom
traefik_http_endpoint
Feb 26, 2023
Merged

Switch Traefik to HTTP endpoint for dynamic config#515
ryanmelt merged 3 commits intomainfrom
traefik_http_endpoint

Conversation

@ryanmelt
Copy link
Copy Markdown
Member

No description provided.

@ryanmelt ryanmelt requested a review from jmthomas February 25, 2023 21:23
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 25, 2023

Codecov Report

Base: 74.05% // Head: 73.98% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (fd709c2) compared to base (6e9e3ef).
Patch coverage: 6.45% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   74.05%   73.98%   -0.08%     
==========================================
  Files         460      460              
  Lines       28391    28422      +31     
  Branches      597      597              
==========================================
+ Hits        21024    21027       +3     
- Misses       7270     7298      +28     
  Partials       97       97              
Flag Coverage Δ
frontend 75.85% <ø> (+0.18%) ⬆️
ruby-api 49.76% <6.45%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...os-cmd-tlm-api/app/controllers/tools_controller.rb 26.08% <ø> (ø)
openc3/lib/openc3/models/microservice_model.rb 93.27% <ø> (-0.17%) ⬇️
openc3/lib/openc3/models/plugin_model.rb 99.39% <ø> (-0.01%) ⬇️
openc3/lib/openc3/version.rb 100.00% <ø> (ø)
...lm-api/app/controllers/microservices_controller.rb 11.76% <3.33%> (-63.24%) ⬇️
openc3-cosmos-cmd-tlm-api/config/routes.rb 100.00% <100.00%> (ø)
...mos-cmd-tlm-api/app/controllers/gems_controller.rb 12.82% <0.00%> (-0.52%) ⬇️
...smos-tool-calendar/src/tools/Calendar/Calendar.vue 72.10% <0.00%> (+3.40%) ⬆️
...tsmonitor/src/tools/LimitsMonitor/LimitsEvents.vue 82.85% <0.00%> (+5.71%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure what you're doing here but it looks like adding the scope broke the unit test. If playwright passes I guess you nailed it.

@ryanmelt ryanmelt merged commit 1c6f2cd into main Feb 26, 2023
@ryanmelt ryanmelt deleted the traefik_http_endpoint branch February 26, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants