Switch Traefik to HTTP endpoint for dynamic config#515
Merged
Conversation
Codecov ReportBase: 74.05% // Head: 73.98% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
==========================================
- Coverage 74.05% 73.98% -0.08%
==========================================
Files 460 460
Lines 28391 28422 +31
Branches 597 597
==========================================
+ Hits 21024 21027 +3
- Misses 7270 7298 +28
Partials 97 97
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jmthomas
reviewed
Feb 25, 2023
Member
jmthomas
left a comment
There was a problem hiding this comment.
Not really sure what you're doing here but it looks like adding the scope broke the unit test. If playwright passes I guess you nailed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.