Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
==========================================
+ Coverage 74.38% 74.75% +0.37%
==========================================
Files 464 454 -10
Lines 28599 28420 -179
Branches 575 544 -31
==========================================
- Hits 21273 21246 -27
+ Misses 7237 7090 -147
+ Partials 89 84 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
| gem 'rack-cors', '~> 2.0' | ||
| gem 'tzinfo-data' | ||
| # httpclient hasn't been released since 2016 so use Shopify's updated one | ||
| gem 'httpclient', git: 'https://github.com/Shopify/httpclient' |
There was a problem hiding this comment.
Can't do this as it always requires an internet connection.
There was a problem hiding this comment.
We probably need to switch to Faraday.
There was a problem hiding this comment.
Could also use HTTP: https://github.com/httprb/http
| # Pass the name of the ENV variable name where we pull the actual bucket name | ||
| response = $api_server.request('get', endpoint, scope: scope) | ||
| if response.nil? || response.code != 200 | ||
| if response.nil? || response.status != 200 |
There was a problem hiding this comment.
This is breaking to other users (including my current CFDP code). Can we make code/status aliases (both work?)
…ython to containers
2 participants
I don't want to merge and release this quite yet since Alpine 3.18.0 is so new