Skip to content

Add ID Value to handbook output#674

Merged
jmthomas merged 1 commit into
mainfrom
id_value
May 22, 2023
Merged

Add ID Value to handbook output#674
jmthomas merged 1 commit into
mainfrom
id_value

Conversation

@jmthomas
Copy link
Copy Markdown
Member

closes #666

@jmthomas jmthomas requested a review from ryanmelt May 19, 2023 15:11
<strong
>ID Value: 0x{{ item.id_value.toString(16).toUpperCase() }}</strong
>
</div>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong and hex to distinguish it a bit. Put after the Default because with commands it is usually the same thing.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (3bf6d9c) 74.77% compared to head (3ca7893) 74.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
- Coverage   74.77%   74.76%   -0.01%     
==========================================
  Files         454      455       +1     
  Lines       28412    28428      +16     
  Branches      545      545              
==========================================
+ Hits        21244    21254      +10     
- Misses       7084     7090       +6     
  Partials       84       84              
Flag Coverage Δ
frontend 77.57% <ø> (-0.05%) ⬇️
ruby-api 51.31% <ø> (-0.06%) ⬇️
ruby-backend 78.42% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmthomas jmthomas merged commit 2ed0df5 into main May 22, 2023
@jmthomas jmthomas deleted the id_value branch May 22, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handbooks ID item value

2 participants