Skip to content

faraday has no reset_all, use close#686

Merged
jmthomas merged 3 commits into
mainfrom
faraday_close
May 26, 2023
Merged

faraday has no reset_all, use close#686
jmthomas merged 3 commits into
mainfrom
faraday_close

Conversation

@ryanmelt
Copy link
Copy Markdown
Member

No description provided.

@ryanmelt ryanmelt requested a review from jmthomas May 26, 2023 17:29
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (16a315c) 70.80% compared to head (0f1a84d) 70.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   70.80%   70.80%           
=======================================
  Files         471      471           
  Lines       30216    30216           
  Branches      822      822           
=======================================
+ Hits        21393    21394    +1     
  Misses       8738     8738           
+ Partials       85       84    -1     
Flag Coverage Δ
frontend 58.66% <ø> (+0.01%) ⬆️
ruby-api 50.64% <ø> (ø)
ruby-backend 78.14% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openc3/lib/openc3/script/screen.rb 20.37% <0.00%> (ø)
openc3/lib/openc3/io/json_api_object.rb 35.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmthomas jmthomas merged commit 860417e into main May 26, 2023
@jmthomas jmthomas deleted the faraday_close branch May 26, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants