Skip to content

ocxl_afp3_latency: Add missing memory barrier#41

Merged
fbarrat merged 1 commit intoOpenCAPI:masterfrom
fbarrat:latency_fix
Apr 7, 2020
Merged

ocxl_afp3_latency: Add missing memory barrier#41
fbarrat merged 1 commit intoOpenCAPI:masterfrom
fbarrat:latency_fix

Conversation

@fbarrat
Copy link
Copy Markdown
Contributor

@fbarrat fbarrat commented Apr 6, 2020

The test does:

  1. clear memory location
  2. trigger the AFU to update memory location
  3. poll memory location

The core may re-order 1 and 2 so we need an explicit memory barrier
between them.

Signed-off-by: Frederic Barrat fbarrat@linux.ibm.com

The test does:
1. clear memory location
2. trigger the AFU to update memory location
3. poll memory location

The core may re-order 1 and 2 so we need an explicit memory barrier
between them.

Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com>
@fbarrat fbarrat requested a review from bmesnet April 6, 2020 13:49
Copy link
Copy Markdown
Contributor

@bmesnet bmesnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable ;-)

@fbarrat
Copy link
Copy Markdown
Contributor Author

fbarrat commented Apr 7, 2020

Fix has been verified on mihawk with 4 cards, each running the test in a loop. The test doesn't hang any more

@fbarrat fbarrat merged commit 2b64325 into OpenCAPI:master Apr 7, 2020
@fbarrat fbarrat deleted the latency_fix branch April 30, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants