fix(groups): return JSON when requesting specific group #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is opposed to returning YAML, which is inconsistent with the format
of the data returned from other API endpoints. Instead of returning a
YAML document like:
description: ""
data:
foo: bar
file:
content:
- 35
- 35
[...snip...]
- 101
- 10
name: ""
encoding: base64
a JSON document with a proper base64-encoded config is returned:
{
"file": {
"content": "IyM[...snip...]ZQo=",
"encoding": "base64",
"filename": ""
},
"meta-data": {
"foo": "bar"
},
"name": "tester"
}
alexlovelltroy
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #56
In the current state, requesting a specific group's data from
/cloud-init/admin/groups/{name}returns a YAML document whose cloud-init file content is a list of integers representing the file's bytes. For example:Instead of this, it would be more consistent and easier to parse if this endpoint returned JSON with a proper base64-encoded config. For example, with this PR:
a JSON document with a proper base64-encoded config is returned:
{ "file": { "content": "IyM[...snip...]ZQo=", "encoding": "base64", "filename": "" }, "meta-data": { "foo": "bar" }, "name": "tester" }