Add 'profile' query parameter in cloud-init metadata handlers#3
Closed
bmcdonald3 wants to merge 10 commits into
Closed
Add 'profile' query parameter in cloud-init metadata handlers#3bmcdonald3 wants to merge 10 commits into
bmcdonald3 wants to merge 10 commits into
Conversation
Signed-off-by: Ben McDonald <ben.mcdonald@hpe.com>
Signed-off-by: Ben McDonald <ben.mcdonald@hpe.com>
Signed-off-by: Ben McDonald <ben.mcdonald@hpe.com>
Signed-off-by: Ben McDonald <ben.mcdonald@hpe.com>
Signed-off-by: Ben McDonald <ben.mcdonald@hpe.com>
Signed-off-by: Ben McDonald <ben.mcdonald@hpe.com>
Signed-off-by: Ben McDonald <ben.mcdonald@hpe.com>
fa4fa02 to
371ae79
Compare
Signed-off-by: Ben McDonald <ben.mcdonald@hpe.com>
Signed-off-by: Ben McDonald <ben.mcdonald@hpe.com>
2056e15 to
6e68c41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add query parameter as phase 1 of OpenCHAMI/roadmap#121.
This covers the following routes as specified in the RFD:
Corresponding changes to boot service and a new node service to follow.
Testing:
Since we are running locally with a fresh
./datadirectory, we must create the group record so the service has a template to serve. We use the generated CLI client for this.We simulate a request from a known mock node (
10.252.0.26) and request a specific profile (staging). We verify that the profile query parameter is preserved in the returned#includeURLs.Seeing
?profile=stagingin the response confirms this change works as expected.