feat: Upgrade for new pre-release of fabrica and address legacy compatibility#4
Merged
Merged
Conversation
…esource handling - Introduced integration tests for metadata handlers in `metadata_integration_test.go` to validate cloud-init flow and syslog metadata isolation. - Updated `metadata_test.go` to ensure empty and missing groups are included in vendor data, aligning with legacy behavior. - Enhanced `group.go` to support base64 template encoding, allowing for more flexible template management. - Added HTTP client implementation in `http_client.go` for SMD API interactions, including caching mechanisms for improved performance. - Updated mock SMD client to support new functionalities and ensure consistency with the HTTP client. - Refactored group resource validation to decode templates based on specified encoding. Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
bmcdonald3
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add integration tests for metadata handlers and enhance group resource handling
metadata_integration_test.goto validate cloud-init flow and syslog metadata isolation.metadata_test.goto ensure empty and missing groups are included in vendor data, aligning with legacy behavior.group.goto support base64 template encoding, allowing for more flexible template management.http_client.gofor SMD API interactions, including caching mechanisms for improved performance.For more info, see Contributing Guidelines.