feat(tokenservice): enhance logging for service token authentication failures and add test for target service mismatch#21
Merged
Conversation
…failures and add test for target service mismatch Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request enhances logging for authentication failures in the service token handler and adds a new test to ensure error messages do not leak sensitive information about target service mismatches. The main changes are grouped into improvements to logging, error handling, and testing.
Logging and error handling improvements:
ServiceTokenHandler, including a new helper methodlogServiceTokenAuthFailurethat logs detailed reasons for denial based on the error message content.Testing improvements:
TestTokenService_ServiceTokenHandler_TargetMismatchReturnsGenericUnauthorizedto verify that when a target service mismatch occurs, the response is a generic unauthorized error and does not leak the specific reason in the response body.stringspackage import toservice_test.goto support new test assertions.Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change
For more info, see Contributing Guidelines.