Fix: ld: warning & Make make build as default target & Print effective config in startup & Add AGENTS.md#1
Merged
RussellLuo merged 3 commits intoOpenCSGs:mainfrom Apr 9, 2026
Merged
Conversation
RussellLuo
reviewed
Apr 9, 2026
| #cgo darwin LDFLAGS: ${SRCDIR}/../../target/debug/libboxlite.a | ||
| #cgo darwin LDFLAGS: -framework CoreFoundation -framework Security -framework IOKit | ||
| #cgo darwin LDFLAGS: -framework Hypervisor -framework vmnet -lresolv | ||
| #cgo darwin LDFLAGS: -framework Hypervisor -framework vmnet |
Collaborator
There was a problem hiding this comment.
Any issues with this option?
Collaborator
Author
There was a problem hiding this comment.
No bugs, but it's deprecated and useless on Mac, My local go1.26.1 outputed warning. (BTW we should update the go version to the latest one go1.26)
Collaborator
There was a problem hiding this comment.
update the go version to the latest one go1.2
LGTM, go ahead.
RussellLuo
reviewed
Apr 9, 2026
| cfg.Server.APIBaseURL = strings.TrimRight(globals.Endpoint, "/") | ||
| } | ||
|
|
||
| a.printEffectiveConfig(cfg) |
Collaborator
There was a problem hiding this comment.
All settings will be written in ~/.csgclaw/config.toml (after csgclaw onboard).
Collaborator
Author
There was a problem hiding this comment.
There could be multiple sources such as envs, flags, config file and so on. So I added the display to show the final effective config.
Collaborator
There was a problem hiding this comment.
Got it. Then should we mask the api_key with asterisks?
RussellLuo
pushed a commit
that referenced
this pull request
Apr 9, 2026
- print effective config on startup (with partially masked secrets) - initialize AGENTS.md - fix ld warning - make `make build` the default target - update Go version
RussellLuo
pushed a commit
that referenced
this pull request
Apr 9, 2026
- print effective config on startup (with partially masked secrets) - initialize AGENTS.md - fix ld warning - make `make build` the default target - update Go version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.