Align PicoClaw runtime workspace layout#100
Merged
RussellLuo merged 2 commits intoMay 25, 2026
Merged
Conversation
jialudev
force-pushed
the
align-picoclaw-openclaw-layout
branch
from
bdb2546 to
6c5b80b
Compare
RussellLuo
reviewed
May 22, 2026
| return "", err | ||
| } | ||
| return filepath.Join(agentHome, hostWorkspaceDir), nil | ||
| return picoclawsandbox.WorkspaceRoot(agentHome), nil |
Collaborator
There was a problem hiding this comment.
This helper now hard-codes the PicoClaw workspace layout, but it is still used from runtime-agnostic paths such as HubPublishSpec().
That means a non-PicoClaw agent, especially OpenClaw, can resolve its exported workspace snapshot from the wrong root: .picoclaw/workspace instead of .openclaw/workspace.
The template-overlay path is still correct because each runtime provisions its own workspace root, but this shared helper no longer looks safe as a generic agent-layer API.
Could we either:
- make this helper runtime-aware, for example resolve by
got.RuntimeKind, or - remove the default workspace-root assumption from
agent/workspace.goand let each runtime or caller provide the host workspace root explicitly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the PicoClaw sandbox creation flow with OpenClaw by using a consistent runtime-root layout, mount structure, and gateway logging behavior across both runtimes.