feat: onboard config persistence and csghub manager robustness#12
Merged
RussellLuo merged 21 commits intoOpenCSGs:mainfrom Apr 25, 2026
Merged
feat: onboard config persistence and csghub manager robustness#12RussellLuo merged 21 commits intoOpenCSGs:mainfrom
RussellLuo merged 21 commits intoOpenCSGs:mainfrom
Conversation
RussellLuo
reviewed
Apr 23, 2026
| managerImage := fs.String("manager-image", "", "bootstrap manager image") | ||
| storagePath := fs.String("storage-path", "", "PVC subpath prefix for all manager/worker sandbox mounts, e.g. 77/<tenant>/") | ||
| storagePathAlias := fs.String("storage_bash", "", "alias for --storage-path") | ||
| forceRecreateManager := fs.Bool("force-recreate-manager", false, "remove and recreate the bootstrap manager box") |
Collaborator
There was a problem hiding this comment.
The parameters for csgclaw onboard may still be simplified later on.
If the relevant settings can be adjusted in the configuration file, we do not recommend adding them to the onboard anymore.
RussellLuo
reviewed
Apr 23, 2026
| if name == "" { | ||
| name = ManagerName | ||
| } | ||
| prefix := strings.TrimSpace(os.Getenv("CSGCLAW_NAME")) |
Collaborator
There was a problem hiding this comment.
Why is an additional environment variable CSGCLAW_NAME required here?
GatewayJ
force-pushed
the
0422
branch
2 times, most recently
from
9571534 to
07ce2a9
Compare
- Add internal/sandbox/csghub runtime/provider and csghubsdk HTTP client - Register csghub sandbox provider; wire config defaults for csghub build - Document env contract in docs/saas-env-contract.md - Add docker/Dockerfile.unified and docker README for unified image - Adjust boxlitesdk imports and provider tests for build-tag layout Excluded from commit: .cursor/, bin-csghub/, third_party local boxlite-c extract (~229MB). Made-with: Cursor
Made-with: Cursor
…notes - Rewrite saas-env-contract intro: no csghub build tag; default go build vs -tags boxlite_sdk; contract applies when using CSGHub sandbox provider - Drop csghub-only DefaultSandboxProvider init file; refresh registry tests - Tweak csghub Provider doc comment; boxlitesdk imports; .gitignore Made-with: Cursor
They belong under .gitignore (bin-csghub/); drop accidental track from 22ee662. Made-with: Cursor
Made-with: Cursor
Remove //go:build boxlite_sdk from internal/sandbox/boxlitesdk sources so go test ./... exercises the adapter without extra tags. Registration and DefaultSandboxProvider override remain behind boxlite_sdk in sandboxproviders and config. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains two groups of changes:
no_authenvironment variable parsing consistency.Onboard Scope (Follow-up to Review Feedback)
Per review feedback,
csgclaw onboardshould stay focused on initialization. This PR removes newly added onboard flags for general server/sandbox settings (such aslisten-addr,advertise-base-url,access-token,sandbox-provider, and storage-path aliases), and keeps those settings managed through the config file.Main Changed Files
cli/onboard/onboard.gocli/onboard/onboard_test.gocli/serve/serve_test.gointernal/agent/runtime.gointernal/agent/service.gointernal/agent/service_test.gointernal/config/config.gointernal/config/config_test.gointernal/sandbox/csghub/*internal/sandboxproviders/csghub_provider.goRisks / Regression Focus
config,agent, andcsghubtest suites.