fix(web): sync agent detail draft on profile refresh#248
Merged
Conversation
youngbeom-shin
requested review from
jialudev and
xxx7xxxx
and removed request for
xxx7xxxx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The agent detail page only reloaded its draft when the routed agent id changed. When the same agent later received a fuller profile payload, the page could keep an older draft baseline and miss dirty-state transitions in the model section.
Validation
pnpm --dir web/app exec vitest run tests/hooks/useAgentController.test.tsx -t "reloads the selected agent draft"pnpm --dir web/app exec vitest run tests/components/AgentActions.test.tsxImpact
This fixes the intermittent case where editing model settings on the agent detail page would not surface an enabled
Save changesbutton.