Skip to content

fix(web): prevent env editor draft crashes#271

Merged
RussellLuo merged 1 commit into
OpenCSGs:mainfrom
GatewayJ:codex/fix-env-editor-crash
Jul 1, 2026
Merged

fix(web): prevent env editor draft crashes#271
RussellLuo merged 1 commit into
OpenCSGs:mainfrom
GatewayJ:codex/fix-env-editor-crash

Conversation

@GatewayJ

@GatewayJ GatewayJ commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • keep agent profile draft comparison tolerant of incomplete environment variable rows
  • preserve strict env and JSON validation for save payloads
  • add a regression test for editing an env row with a missing key

Validation

  • pnpm --dir web/app test -- tests/models/agents.test.ts
  • pnpm --dir web/app typecheck
  • pnpm --dir web/app lint
  • pnpm --dir web/app format:check
  • make build-web

Impact

Prevents the Agent profile advanced environment variable editor from crashing while users are still typing a new row.

@GatewayJ GatewayJ marked this pull request as ready for review July 1, 2026 13:43
@GatewayJ GatewayJ requested a review from RussellLuo July 1, 2026 13:43
@RussellLuo RussellLuo merged commit 690a7c0 into OpenCSGs:main Jul 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants