Refactor workspace routing, controllers, and styling#88
Merged
Conversation
- Replaced existing color tokens with a new palette for light and dark themes. - Introduced new variables for gray and brand colors to enhance UI consistency. - Updated font families for better typography across the application. - Adjusted shadow and border styles for improved visual hierarchy. - Ensured accessibility by refining color contrasts and focus indicators.
- Implemented `useWorkspaceHubController` to manage hub templates and errors. - Created `useWorkspaceShellController` for handling workspace shell state and interactions. - Refactored `useWorkspaceNavigation` to remove unnecessary state management for channel tools and member list. - Updated tests to reflect changes in navigation hook usage. - Adjusted legacy contract test to ensure correct hub template creation behavior.
- Added a new types file to define various types used across workspace hooks. - Updated `useAgentController`, `useConversationController`, `useProfilePreviewController`, and other hooks to utilize the new types for better type safety. - Enhanced `useWorkspaceNavigation` and `useWorkspaceShellController` to improve navigation handling and workspace shell management. - Refactored several functions to include type annotations for parameters and return types, improving code clarity and maintainability. - Introduced new properties in the `AgentLike` type to support additional agent attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains four workspace web updates:
Make workspace navigation router-first.
pathForPaneand React Router navigation so deep links, aliases, and browser back/forward behavior stay consistent.Split the workspace controller into focused hooks.
useWorkspaceControlleras the composition layer forWorkspacePage.Reorganize workspace styling and theme tokens.
Remove legacy static frontend assets.
web/staticcomparison assets now that the Vite app is the maintained frontend.web/apptoweb/static-distbuild flow.Testing