- 
                Notifications
    
You must be signed in to change notification settings  - Fork 3
 
Upgrade data-flow #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
        
          
                Dockerfile
              
                Outdated
          
        
      | # CMD ["df-server"] | ||
| CMD ["uvicorn", "data_server.main:app", "--host", "0.0.0.0", "--port", "8000"] | ||
| 
               | 
          ||
| # # 复制并设置 entrypoint.sh 脚本的权限 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please just use english in all code comments and readm.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not remove current license file
        
          
                README.md
              
                Outdated
          
        
      | -e POSTGRES_USER=postgres \ | ||
| -e POSTGRES_PASSWORD=postgres \ | ||
| opencsg-registry.cn-beijing.cr.aliyuncs.com/opencsg_public/csghub/postgres:15.10 | ||
| opencsg-registry.cn-beijing.cr.aliyuncs.com/opencsg_public/postgres | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave postgres to 15.10
        
          
                Dockerfile
              
                Outdated
          
        
      | 
               | 
          ||
| # # 复制并设置 entrypoint.sh 脚本的权限 | ||
| # COPY entrypoint.sh /entrypoint.sh | ||
| # RUN chmod +x /entrypoint.sh | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those change required?
| 
               | 
          ||
| ``` | ||
| 
               | 
          ||
| ## Run server in development mode locally | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why delete those debug section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove useless images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove test file
| with open(readme_path, encoding='utf-8') as stream: | ||
| content = stream.read() | ||
| else: | ||
| with open(readme_path) as stream: # 在 Linux 和 macOS 下不显式指定编码 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注释改一下
        
          
                data_celery/datasource/file/tasks.py
              
                Outdated
          
        
      | @celery_app.task(name="collection_file_task") | ||
| def collection_file_task(task_uid: str,user_name: str,user_token: str): | ||
| """ | ||
| 采集任务 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注释
        
          
                data_celery/db/DatasourceManager.py
              
                Outdated
          
        
      | 
               | 
          ||
| def get_collection_task_by_uid(db_session: Session, task_uid: str): | ||
| """ | ||
| 根据任务UID获取唯一的采集任务信息 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注释
        
          
                data_celery/db/FormatifyManager.py
              
                Outdated
          
        
      | """ | ||
| 获取格式转换任务信息 | ||
| Args: | ||
| db_session (Session): 数据库会话 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注释
        
          
                data_celery/db/JobsManager.py
              
                Outdated
          
        
      | 
               | 
          ||
| def get_pipline_job_by_uid(db_session: Session, job_uid: str): | ||
| """ | ||
| 根据任务UID获取唯一的pipline任务信息 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注释
        
          
                data_celery/formatify/tasks.py
              
                Outdated
          
        
      | task_uid: str | ||
| ): | ||
| insert_formatity_task_log_info(task_uid, | ||
| f"转换目录:{tmp_path},源文件类型:{getFormatTypeName(from_type)},目标文件类型:{getFormatTypeName(to_type)}") | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log
| -v /home/redisdata:/data \ | ||
| -e MONGO_INITDB_ROOT_USERNAME=root \ | ||
| -e MONGO_INITDB_ROOT_PASSWORD=example \ | ||
| opencsg-registry.cn-beijing.cr.aliyuncs.com/opencsghq/redis:7.2.5 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mongodb 的环境变量放到了redis 来了
No description provided.