Oc 6126 add get person by email#19
Merged
killianherbunot merged 8 commits intomasterfrom Nov 21, 2016
Merged
Conversation
killianherbunot
force-pushed
the
OC-6126_add_get_person_by_email
branch
from
eb0eb2b to
7aaf204
Compare
killianherbunot
force-pushed
the
OC-6126_add_get_person_by_email
branch
from
7aaf204 to
311816b
Compare
…srooms/FrontDesk into OC-6126_add_get_person_by_email
…6126_add_get_person_by_email
killianherbunot
force-pushed
the
OC-6126_add_get_person_by_email
branch
4 times, most recently
from
025bccc to
791d8fa
Compare
killianherbunot
force-pushed
the
OC-6126_add_get_person_by_email
branch
from
791d8fa to
15dfb43
Compare
arnaud-23
suggested changes
Nov 21, 2016
|
|
||
| /** | ||
| * @param string $query | ||
| * |
| * {@inheritdoc} | ||
| */ | ||
| public function withCustomFields(array $customFields) | ||
| public function withCustomFields(array $customFields = null) |
src/Models/Person.php
Outdated
| * @param array $customFields | ||
| */ | ||
| public function setCustomFields(array $customFields) | ||
| public function setCustomFields(array $customFields = null) |
src/Models/PersonBuilder.php
Outdated
| * @return PersonBuilder | ||
| */ | ||
| public function withCustomFields(array $customFields); | ||
| public function withCustomFields(array $customFields = null); |
src/Repository/PersonRepository.php
Outdated
| { | ||
| const RESOURCE_NAME = ApiEndpoint::DESK.'/people/'; | ||
|
|
||
| const SEARCH_NAME = 'search'; |
src/Repository/PersonRepository.php
Outdated
| $result = json_decode($jsonResult, true); | ||
| $result = $result['people']; | ||
|
|
||
| return $this->buildPeople($result); |
There was a problem hiding this comment.
you can write directly php return $this->buildPeople($result['people']);(you save 1 line of code ;) )
| return $this->personGateway->findAll($page); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
you can rename this method by 'search'
|
|
||
| /** | ||
| * @test | ||
| */ |
There was a problem hiding this comment.
you aren't oblige to write [0 => ...] because an array begin ever by 0
|
|
||
| /** | ||
| * @test | ||
| */ |
There was a problem hiding this comment.
if you put a array of person you should pluralize this variable PersonGatewayMock::$person
arnaud-23
approved these changes
Nov 21, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.