Get visit service by killianherbunot · Pull Request #6 · OpenClassrooms/FrontDesk

killianherbunot · 2016-10-24T09:17:21Z

No description provided.

…_visit_service

arnaud-23 · 2016-10-25T12:32:46Z

src/Client/ApiClient.php


    /**
     * @param string $resourceName
+     * @param object $resourceData


arnaud-23 · 2016-10-25T12:33:41Z

src/Gateways/VisitGateway.php

+interface VisitGateway
+{
+    /**
+     * @param integer $personId


what about "from" and "to" ?

arnaud-23 · 2016-10-25T12:35:06Z

src/Models/Impl/VisitBuilderImpl.php

+    private $visit;
+
+    /**
+     * @return VisitBuilder


inheritdoc (same for the entire method of this class)

arnaud-23 · 2016-10-25T12:45:46Z

src/Repository/VisitRepository.php

+ */
+class VisitRepository implements VisitGateway
+{
+    const RESOURCE_NAME = 'desk/people/';


we don't add the last "/" for other resource name do the same here

arnaud-23 · 2016-10-25T12:49:18Z

tests/Repository/VisitRepositoryTest.php

+ */
+class VisitRepositoryTest extends \PHPUnit_Framework_TestCase
+{
+    const FROM = "2016-08-12 15:30:06";


single quote

arnaud-23 · 2016-10-25T12:50:04Z

tests/Repository/VisitRepositoryTest.php

+     */
+    public function findAllByPersonIdWithoutParameters_ReturnVisits()
+    {
+        ApiClientMock::$response = json_encode(["visits" => [new VisitStub1()], "total_count" => 1]);


arnaud-23 · 2016-10-25T12:50:12Z

tests/Repository/VisitRepositoryTest.php

+    public function findAllByPersonIdWithParameters_ReturnVisits()
+    {
+        list($from, $to) = $this->initFromAndTo();
+        ApiClientMock::$response = json_encode(["visits" => [new VisitStub1()], "total_count" => 1]);


arnaud-23 · 2016-10-25T12:51:42Z

tests/Repository/VisitRepositoryTest.php

+        ApiClientMock::$response = json_encode(["visits" => [new VisitStub1()], "total_count" => 1]);
+
+        $visits = $this->visitRepository->findAllByPersonId(PersonStub1::ID);
+        $this->assertEquals(json_encode([new VisitStub1()]), json_encode($visits));


what about the use of the assertVisit in VisitTestCase trait ?

arnaud-23 · 2016-10-25T12:53:49Z

tests/Services/Impl/VisitServiceImplTest.php

+    /**
+     * @param Visit[] $visits
+     */
+    public function doTestVisit($visits)


assertVisits

not sure, i'm only test one visit at a time.

nop, you test an array of visit ;)

arnaud-23 · 2016-10-25T12:54:34Z

tests/Services/Impl/VisitServiceImplTest.php

+     */
+    public function doTestVisit($visits)
+    {
+        $this->assertEquals(0, count($visits) - count(VisitGatewayMock::$visits));


arnaud-23 · 2016-10-25T14:09:11Z

tests/Repository/PlanRepositoryTest.php


        $plans = $this->planRepository->findAllByPersonId(PersonStub1::ID);
-        $this->assertEquals(json_encode([new PlanStub1()]), json_encode($plans));
+        $this->assertEquals(0, count($plans) - count(PlanGatewayMock::$plans));


arnaud-23 · 2016-10-25T14:09:15Z

tests/Repository/PlanRepositoryTest.php

    {
        $this->planRepository = new PlanRepository();
        $this->planRepository->setApiClient(new ApiClientMock());
+        PlanGatewayMock::$plans = new PlanStub1();


arnaud-23 · 2016-10-25T14:09:44Z

tests/Repository/VisitRepositoryTest.php

+     */
+    public function doTestVisits($visits)
+    {
+        $this->assertEquals(0, count($visits) - count(VisitGatewayMock::$visits));


arnaud-23 · 2016-10-25T14:10:09Z

tests/Repository/VisitRepositoryTest.php

    {
        $this->visitRepository = new VisitRepository();
        $this->visitRepository->setApiClient(new ApiClientMock());
+        VisitGatewayMock::$visits = new VisitStub1();


arnaud-23 · 2016-10-25T14:10:55Z

tests/Repository/VisitRepositoryTest.php

+    /**
+     * @param Visit[] $visits
+     */
+    public function doTestVisits($visits)


assertVisits and you can move it on VisitTestCase Trait

arnaud-23 · 2016-10-25T14:26:14Z

tests/Doubles/Models/VisitTestCase.php

+    /**
+     * @param Visit[] $visits
+     */
+    public function assertVisits($visits)


(array $visits) :)

you need it in your VisitServiceImpl too

killianherbunot added 5 commits October 20, 2016 12:14

Add Plan Service

faa20e0

Add Plan Model + Update Tests

2580406

Add DeletePack Service

d27d735

Add get visit Service

569026e

Merge branch 'master' of github.com:OpenClassrooms/FrontDesk into get…

ff34cde

…_visit_service

killianherbunot force-pushed the get_visit_service branch from aab1145 to 514c8a2 Compare October 25, 2016 12:29

arnaud-23 suggested changes Oct 25, 2016

View reviewed changes

killianherbunot force-pushed the get_visit_service branch from 0e50409 to 63596b3 Compare October 25, 2016 13:51

arnaud-23 suggested changes Oct 25, 2016

View reviewed changes

arnaud-23 approved these changes Oct 25, 2016

View reviewed changes

add test + clean

d8c4ef1

killianherbunot force-pushed the get_visit_service branch from 43ec7cd to d8c4ef1 Compare October 25, 2016 14:39

killianherbunot merged commit 75bdc0e into master Oct 25, 2016

killianherbunot deleted the get_visit_service branch October 26, 2016 16:26

Conversation

killianherbunot commented Oct 24, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants