feat(security): add ability to by pass security #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidux
force-pushed
the
add-ability-to-by-pass-security
branch
from
fff4231 to
1858e2f
Compare
sidux
force-pushed
the
add-ability-to-by-pass-security
branch
3 times, most recently
from
8e7d774 to
9b71699
Compare
|
Issued by Coverage Checker: |
sidux
force-pushed
the
add-ability-to-by-pass-security
branch
from
9b71699 to
66df5e7
Compare
sidux
force-pushed
the
add-ability-to-by-pass-security
branch
from
66df5e7 to
e15ce39
Compare
Wilkins
approved these changes
Nov 20, 2024
Comment on lines
+43
to
+45
| if ($this->config?->bypassSecurity) { | ||
| return new Response(); | ||
| } |
Contributor
There was a problem hiding this comment.
Are we sure we're not creating a backdoor usable larger than we expect ?
Contributor
Author
There was a problem hiding this comment.
there two things to secure against this in the other PR :
app.php which is used in prod, always forces bypass env var to 0
only service proxy
config is only loaded in dev/openclassrooms_service_proxy.yml which is loaded only in dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useful when debugging (will be activated using an env var)