Fix audio context and microphone listener cleanup leaks#325
Merged
Conversation
…ource accumulation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes memory/resource leaks in the WebRTC audio and microphone management paths by ensuring explicit cleanup of native audio objects and stream listeners.
Main changes:
GfnWebRtcClient (
opennow-stable/src/renderer/src/gfn/webrtcClient.ts):audioSourceNodefield to track theMediaStreamAudioSourceNodeused for remote audio routing.cleanupAudioRouting()helper to idempotently disconnect the source node, close theAudioContext, and reset the audio element state.cleanupPeerConnection()to callcleanupAudioRouting()instead of inline logic.startDirectAudioPlayback()is invoked.MicrophoneManager (
opennow-stable/src/renderer/src/gfn/microphoneManager.ts):inactivestream listener with a stable, stored handler (handleMicStreamInactive).attachMicStream(),detachMicStreamListeners(), andclearMicStream()helpers to manage listener lifecycle.startCapture()to clear previous streams and attach listeners viaattachMicStream().stop()to useclearMicStream()instead of inline cleanup.OverconstrainedErrorfallback path also attaches listeners correctly.