Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the hardcoded 180-second timeout for session readiness (
SESSION_READY_TIMEOUT_MS). The timeout was previously enforced during the setup/starting phase after clearing the queue, causing launch failures when rig allocation exceeded 3 minutes.Changes:
opennow-stable/src/renderer/src/App.tsx):SESSION_READY_TIMEOUT_MSconstant (line 108).setupTimeoutStartAttracking and timeout check logic (lines 2693-2694, 2771-2793).The polling loop will now continue indefinitely in both queue and setup/starting states until the session status reaches ready (
status === 2 || status === 3) or the launch is explicitly aborted via the UI.