Conversation
- Update session storage to use signaling URL directly from API response - Add validation for malformed URLs (starting with dot) in get_webrtc_config - Fall back to server IP when signaling URL is malformed Bump version to 0.0.22
Contributor
There was a problem hiding this comment.
Pull request overview
This emergency fix resolves WebRTC connection failures for Zain alliance partner streaming caused by malformed signaling URLs returned by the API. The fix addresses URLs like rtsps://.zai.geforcenow.nvidiagrid.net:322 that are missing the server IP address.
- Updates session storage to preserve the raw signaling URL from the API polling response
- Adds validation in WebRTC config to detect malformed URLs (hostnames starting with
.) - Implements fallback to use the server control IP when URLs are malformed
- Bumps version to 0.0.22 across all package files
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src-tauri/src/streaming.rs | Adds signaling URL storage from API response and validation logic to detect/handle malformed URLs with fallback to server IP |
| src-tauri/tauri.conf.json | Version bump to 0.0.22 |
| src-tauri/Cargo.toml | Version bump to 0.0.22 |
| package.json | Version bump to 0.0.22 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
zortos293
added a commit
that referenced
this pull request
Feb 21, 2026
v0.0.22: Emergency fix for Zain alliance partner streaming
zortos293
added a commit
that referenced
this pull request
Feb 21, 2026
v0.0.22: Emergency fix for Zain alliance partner streaming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtsps://.zai.geforcenow.nvidiagrid.net:322) missing the server IP, causing WebRTC connection failuresChanges
src-tauri/src/streaming.rs: Fix signaling URL handling for alliance partners