Skip to content

build: Package release artifacts as ZIP archives for all platforms#94

Merged
zortos293 merged 1 commit intomainfrom
Native
Jan 4, 2026
Merged

build: Package release artifacts as ZIP archives for all platforms#94
zortos293 merged 1 commit intomainfrom
Native

Conversation

@zortos293
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings January 4, 2026 21:44
@zortos293 zortos293 merged commit 1c8a4a1 into main Jan 4, 2026
8 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes the packaging of release artifacts across all platforms by creating ZIP archives before uploading, instead of uploading raw binaries and DLLs. This ensures consistent distribution format and easier downloads for end users.

Key Changes:

  • Added ZIP creation steps for Windows (x64 and ARM64) and Linux (x64 and ARM64) platforms
  • Updated artifact upload paths to reference the newly created ZIP files instead of individual binaries
  • Updated GitHub Release upload steps to use ZIP archives for all platforms

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

shell: bash
run: |
cd opennow-streamer/target/aarch64-unknown-linux-gnu/release
zip -r "OpenNOW-linux-arm64.zip" bundle/
Copy link

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Linux ARM64 artifact zips a directory named "bundle/" while other platforms zip specific files. This inconsistency could lead to different archive structures across platforms. Consider either:

  1. Zipping the contents of bundle/ using "bundle/*" if bundle/ is a directory containing multiple files, or
  2. Documenting why Linux ARM64 requires a different structure than other platforms

Additionally, verify that the "bundle/" directory exists at this path - the original code uploaded "bundle/*" which suggests it's a directory with contents.

Suggested change
zip -r "OpenNOW-linux-arm64.zip" bundle/
zip -r "OpenNOW-linux-arm64.zip" bundle/*

Copilot uses AI. Check for mistakes.
run: |
$releaseDir = "opennow-streamer/target/release"
$zipName = "OpenNOW-windows-x64.zip"
Compress-Archive -Path "$releaseDir\opennow-streamer.exe", "$releaseDir\*.dll" -DestinationPath "$releaseDir\$zipName"
Copy link

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Compress-Archive command with wildcard patterns may not work as expected in PowerShell. When using Compress-Archive with comma-separated paths where one includes a wildcard, the wildcard may not expand properly. Consider using Get-ChildItem to explicitly resolve the DLL files:

$files = @("$releaseDir\opennow-streamer.exe") + (Get-ChildItem "$releaseDir\*.dll")
Compress-Archive -Path $files -DestinationPath "$releaseDir\$zipName"

Or zip all files in the directory and filter as needed. This ensures all DLLs are reliably included in the archive.

Copilot uses AI. Check for mistakes.
run: |
$releaseDir = "opennow-streamer/target/aarch64-pc-windows-msvc/release"
$zipName = "OpenNOW-windows-arm64.zip"
Compress-Archive -Path "$releaseDir\opennow-streamer.exe", "$releaseDir\*.dll" -DestinationPath "$releaseDir\$zipName"
Copy link

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Compress-Archive command with wildcard patterns may not work as expected in PowerShell. When using Compress-Archive with comma-separated paths where one includes a wildcard, the wildcard may not expand properly. Consider using Get-ChildItem to explicitly resolve the DLL files:

$files = @("$releaseDir\opennow-streamer.exe") + (Get-ChildItem "$releaseDir\*.dll")
Compress-Archive -Path $files -DestinationPath "$releaseDir\$zipName"

Or zip all files in the directory and filter as needed. This ensures all DLLs are reliably included in the archive.

Copilot uses AI. Check for mistakes.
zortos293 added a commit that referenced this pull request Feb 21, 2026
build: Package release artifacts as ZIP archives for all platforms
zortos293 added a commit that referenced this pull request Feb 21, 2026
build: Package release artifacts as ZIP archives for all platforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants