Skip to content

nettrace: allow to use drop-stack in any mode #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022
Merged

nettrace: allow to use drop-stack in any mode #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/trace.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ static void trace_all_set_ret()

static int trace_prepare_args()
{
trace_t *drop_trace = search_trace_enabled("kfree_skb");
trace_args_t *args = &trace_ctx.args;
char *traces = args->traces;
trace_t *trace;
Expand All @@ -195,12 +196,15 @@ static int trace_prepare_args()
if (args->intel)
trace_ctx.mode = TRACE_MODE_INETL;

if (args->drop_stack) {
if (trace_set_stack(drop_trace))
goto err;
}

if (args->drop) {
trace_ctx.mode = TRACE_MODE_DROP;
traces = "kfree_skb";
} else if (args->drop_stack) {
pr_err("--drop should be set!\n");
goto err;
trace_set_enable(drop_trace);
goto skip_trace;
}

if (!traces) {
Expand Down Expand Up @@ -247,15 +251,11 @@ static int trace_prepare_args()
trace_group_enable("life");
break;
case TRACE_MODE_BASIC:
break;
case TRACE_MODE_DROP: {
trace_t *drop_trace = search_trace_enabled(traces);

if (!trace_ctx.drop_reason)
pr_warn("skb drop reason is not support by your kernel"
", drop reason will not be printed\n");

if (args->drop_stack && trace_set_stack(drop_trace))
goto err;
break;
}
default:
Expand Down