Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This extracts the PHP-side shared Lua core into
opencompanyapp/integration-core.The package now includes:
LuaToolInvokercontractLuaBridgefor routingapp.*calls to tool slugsLuaCatalogBuilderfor namespace/function/parameter map generationLuaDocRendererfor namespace docs, function docs, search, and summariesWhy
OpenCompany and KosmoKrator need to share the same Lua-facing bridge/catalog/docs layer without duplicating the path routing and doc generation logic in each host.
Keeping this in
integration-corepreserves a small package surface:integration-coreowns shared tool contracts and shared Lua PHP logicintegration-*packages stay focused on actual integrationslua-sandboxruntime remains separateprism-relayremains focused on provider normalizationImpact
This PR does not yet wire host applications to the extracted classes by itself. It establishes the reusable package layer that host adapters can consume.
Validation
Validated by syntax-checking the new PHP files and then consuming the extracted classes from OpenCompany locally, where the affected Lua feature tests passed:
tests/Feature/LuaApiDocGeneratorTest.phptests/Feature/LuaBridgeTest.phptests/Feature/Tools/LuaExecTest.php