Conversation
MKodde
force-pushed
the
feature/update-symfony-support
branch
from
aadb6c4 to
1496323
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=========================================
Coverage 41.17% 41.17%
Complexity 52 52
=========================================
Files 12 12
Lines 153 153
=========================================
Hits 63 63
Misses 90 90
☔ View full report in Codecov by Sentry. |
MKodde
force-pushed
the
feature/update-symfony-support
branch
from
1496323 to
4d2e2d7
Compare
MKodde
force-pushed
the
feature/update-symfony-support
branch
from
4d2e2d7 to
e97bbfc
Compare
Contributor
|
I have created a PR to support Symfony 7. |
Chris53897
reviewed
Oct 31, 2023
| "phpunit/phpunit": "^9.6|^10.4", | ||
| "sebastian/phpcpd": "^4.1|^5.0|^6.0", | ||
| "squizlabs/php_codesniffer": "^3.6", | ||
| "malukenho/docheader": "^0.1.8", |
Contributor
There was a problem hiding this comment.
I think this can be changed to "malukenho/docheader": "^0.1.8|^1.0",
But needs check for BC breaks.
This will fix the failing composer install. https://github.com/OpenConext/Monitor-bundle/actions/runs/6704694822
Member
Author
There was a problem hiding this comment.
Thanks for the suggestion @Chris53897
I'll be updating and testing this right away
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the new version of the Bundle (4.0.0) we aim to drop SF 4.4. support and start allowing SF 7 use
I also dropped support for PHP 7 and <8.2.