fixes: issue-27 Logging for db exception should be more context rich#28
Open
kayjoosten wants to merge 2 commits intomainfrom
Open
fixes: issue-27 Logging for db exception should be more context rich#28kayjoosten wants to merge 2 commits intomainfrom
kayjoosten wants to merge 2 commits intomainfrom
Conversation
When you run composer install with php 8.5 it will break. Therefore, we have to lock the version to 8.2 this is bcuz we want to support from 8.2 onwards not from 8.5
Fixes #27. Exceptions caught in DoctrineConnectionHealthCheck and HealthController were silently swallowed, making database failures impossible to diagnose from logs. Inject LoggerInterface and log the full exception as context so Monolog includes the stack trace.
kayjoosten
changed the title
johanib
approved these changes
Apr 13, 2026
johanib
left a comment
johanib
left a comment
There was a problem hiding this comment.
👍 Passing the $exception to the log will include the needed context for the operator.
Be aware that the original ticket mentions engineblock. The DoctrineConnectionHealthCheck from this repo does not get used in EB, EB overrides that healthcheck. So might be worth it to also apply the changes in that Healthcheck.
Author
|
Good catch ill check if it's needed there aswell |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.