Prevent 'Aborted connection' warnings from the DoctrineConnectionHealthCheck#3
Merged
Prevent 'Aborted connection' warnings from the DoctrineConnectionHealthCheck#3
Conversation
Member
|
In my test, does not seem to have the desired effect. |
5f304d8 to
4e9a929
Compare
Contributor
|
Nope, indeed still loads of aborted db-connections from engine, middleware and gateway: |
Prevent sleeping connections in the database which get aborted eventually. This in order to prevent growing logs.
Contributor
Author
|
We've tested the issue on the test environment and could reproduce the problem there. The problem was that the wrong method was used and therefore the connections were not properly closed. This fix should now address this issue. |
Member
|
Yes, works better now! |
Member
|
@pablothedude, would you be so kind to install this change in:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aborted connection warnings where spawned into the
messageslog on every call to the health endpoint. Many sleeping mysql tasks remained unclosed.To resolve this issue, the DoctrineConnectionHealthCheck needed to be changed. The previously used
executestatement turned out to cause the problem. Using thequerymethod solved the problem.