Feature/add ci tests for php8.2#9
Merged
MKodde merged 3 commits intoOpenConext:mainfrom Oct 31, 2023
Merged
Conversation
Codecov ReportBase: 42.17% // Head: 41.17% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #9 +/- ##
============================================
- Coverage 42.17% 41.17% -1.01%
Complexity 52 52
============================================
Files 12 12
Lines 147 153 +6
============================================
+ Hits 62 63 +1
- Misses 85 90 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
Author
|
The failing test is because of malukenho/docheader ^0.1.8 and not v.1. |
MKodde
approved these changes
Oct 31, 2023
Member
MKodde
left a comment
MKodde
left a comment
There was a problem hiding this comment.
Thanks for the contribution @Chris53897
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improve amount of ci runs, because we only need one lowest run. Yes, i am aware of that i introduced that at the start ;)
php: '7.2'
stability: prefer-lowest