fix(theme): replace jshint with eslint to resolve minimatch vulnerability#1943
Merged
fix(theme): replace jshint with eslint to resolve minimatch vulnerability#1943
Conversation
johanib
force-pushed
the
feature/update-js
branch
from
8ebd4d6 to
a2d1fa5
Compare
kayjoosten
reviewed
Mar 17, 2026
…lity jshint@2.13.6 requires minimatch@~3.0.2 which excludes all non-vulnerable versions (>=3.1.4), making a Dependabot security update impossible. - Replace jshint with eslint@^9.0 + globals@^16.0 in devDependencies - Add eslint.config.js with eslint:recommended, browser globals, and caughtErrors:none for no-unused-vars - Fix no-case-declarations in keyboardBehaviour.js - Suppress no-self-assign for intentional screen reader hack in showOrHideNoResultsSection.js
johanib
force-pushed
the
feature/update-js
branch
from
a2d1fa5 to
88f8537
Compare
kayjoosten
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jshint@2.13.6 requires minimatch@~3.0.2 which excludes all non-vulnerable versions (>=3.1.4), making a Dependabot security update impossible.