Reject metadata push when IdP discovery entry is missing English name#1957
Merged
kayjoosten merged 2 commits intomainfrom Apr 13, 2026
Merged
Reject metadata push when IdP discovery entry is missing English name#1957kayjoosten merged 2 commits intomainfrom
kayjoosten merged 2 commits intomainfrom
Conversation
A discovery entry without name_en was silently dropped, which could leave an IdP with no discoveries and cause a WAYF crash. Now throws InvalidDiscoveryException, which propagates to ConnectionsController as HTTP 400. Fixes #1865.
kayjoosten
force-pushed
the
fix/1865-reject-push-missing-discovery-name
branch
from
53fbc96 to
ba9137a
Compare
johanib
requested changes
Apr 7, 2026
Contributor
johanib
left a comment
johanib
left a comment
There was a problem hiding this comment.
lgtm, 1 improvement that we should still add imo
src/OpenConext/EngineBlock/Metadata/Entity/Assembler/DiscoveryAssembler.php
Show resolved
Hide resolved
johanib
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
discoveriesentry that has no English name (name_en), EngineBlock now rejects the push with HTTP 400 instead of silently dropping the entryDiscoveryAssembler::assembleDiscoveries()to throwInvalidDiscoveryExceptioninstead of silently skipping; the existingConnectionsControllercatch-all propagates this as HTTP 400DiscoveryAssemblerTest), assembler integration (PushMetadataAssemblerTest), and HTTP functional (ConnectionsControllerTest)Test plan
./vendor/bin/phpunit --configuration=./tests/phpunit.xml --testsuite=unit,integrationPOST /api/connectionswith an IdP discovery missingname_enreturns HTTP 400 with an error message containingname_enname_en) still succeeds