Fix the token sorting #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The token sorting was broken because of a wrongly given collection. This commit should fix the sorting for all columns.
Contributor
Author
MKodde
approved these changes
Jan 14, 2019
Member
MKodde
left a comment
MKodde
left a comment
There was a problem hiding this comment.
Works like a charm. Tested with a test set of tokens in the 'ra_second_factor' projection
MKodde
added a commit
that referenced
this pull request
Mar 20, 2019
Other controller actions use the paginator to paginate their results, sorting was broken in certain situations. This was fixed for the token overview in #185, but not fixed for the other paginator usages. This should fix the `UnexpectedTypeException` 'PropertyAccessor requires a graph of objects or arrays to operate on error See: https://www.pivotaltracker.com/story/show/164729675
MKodde
added a commit
that referenced
this pull request
May 2, 2019
Apply fix from #185 to other paginate calls
MKodde
added a commit
that referenced
this pull request
May 2, 2019
Other controller actions use the paginator to paginate their results, sorting was broken in certain situations. This was fixed for the token overview in #185, but not fixed for the other paginator usages. This should fix the `UnexpectedTypeException` 'PropertyAccessor requires a graph of objects or arrays to operate on error See: https://www.pivotaltracker.com/story/show/164729675
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The token sorting was broken because of a wrongly given collection.
This commit should fix the sorting for all columns.