feat(shared,desktop): add provider capability profiles#215
Merged
Conversation
10 tasks
Contributor
There was a problem hiding this comment.
Findings
- [Blocker] Missing DCO sign-off —
CLAUDE.mdmarksSigned-off-byas required, but the only PR commit41a0717e9c86e82fe4f80a9ef383f3adacfbbedehas messagefeat(shared,desktop): add provider capability profileswith noSigned-off-by:trailer.
Suggested fix:git commit --amend -s --no-edit git push --force-with-lease
Summary
- Review mode: initial. One blocker found: the PR currently misses the required DCO sign-off.
docs/VISION.mdanddocs/PRINCIPLES.mdwere not found inrepo/docsin this checkout, so policy checks were limited toCLAUDE.mdplus the touched source.- No additional high-confidence issues were identified in the added/modified lines.
Testing
- Not run (automation environment:
pnpmnot installed)
open-codesign Bot
Signed-off-by: Sun-sunshine06 <Sun-sunshine06@users.noreply.github.com>
41a0717 to
c62d1bf
Compare
Contributor
There was a problem hiding this comment.
Findings
- No high-confidence issues found in the added/modified lines.
Summary
- Review mode: follow-up after new commits. The previous DCO blocker is resolved on commit
c62d1bf76d2d8224047784ef3988b06e9dfda22e. - No new correctness, security, regression, or hard-constraint issues were identified in the latest diff.
docs/VISION.mdanddocs/PRINCIPLES.mdwere not found in this checkout, so policy checks were limited toCLAUDE.mdplus the touched source.- Residual risk: broader integration coverage for provider import/discovery flows was not verified in this run.
Testing
- Not run (automation): workspace dependencies are not installed in this runner (
vitest: not found), and the available Node version isv20.20.2while the repo requires>=22.
open-codesign Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
This PR lands a minimal first step for #206 by introducing explicit provider capability profiles into the shared config model and wiring keyless checks to use them.
这个 PR 先为 #206 落一个尽量小的第一步:在 shared config model 中引入显式的 provider capability profile,并让 keyless 判定开始基于这层能力信息。
What changed / 变更内容
ProviderCapabilitiesSchemaandProviderModelDiscoveryModeSchemainpackages/shareddefaultProviderCapabilities()andresolveProviderCapabilities()helpersProviderEntryto persist optionalcapabilitiesstatic-hint+ keyless via explicit capabilitiesisKeylessProviderAllowed()to consult resolved capabilities firstWhy this shape / 为什么这样做
This keeps the scope small while laying groundwork for follow-up issues:
这一版不尝试一次性把 capability profile 接到所有链路里,而是先把 schema、默认值和解析 helper 稳定下来,并优先接入已经反复遇到问题的 keyless 判定逻辑,方便后续几个子 issue 继续往上叠。
Testing / 验证
Pre-push checks ran successfully:
biome check .Note: Biome still reports one unrelated pre-existing warning in
apps/desktop/src/renderer/src/components/Settings.tsxabout exhaustive deps. This PR does not touch that file.备注:Biome 仍会报告一个与本 PR 无关的已有 warning,位置在
apps/desktop/src/renderer/src/components/Settings.tsx,本次改动没有涉及该文件。Refs #206
Refs #214