Skip to content

fix(lint): resolve biome check failures blocking push#224

Merged
Sun-sunshine06 merged 2 commits intoOpenCoworkAI:mainfrom
Jiangxy-1:claude/nostalgic-lamarr-c1bad6
Apr 24, 2026
Merged

fix(lint): resolve biome check failures blocking push#224
Sun-sunshine06 merged 2 commits intoOpenCoworkAI:mainfrom
Jiangxy-1:claude/nostalgic-lamarr-c1bad6

Conversation

@Jiangxy-1
Copy link
Copy Markdown
Contributor

@Jiangxy-1 Jiangxy-1 commented Apr 24, 2026

Summary

Remove spurious pushToast from a useEffect dependency array in Settings.tsx where it was listed but never used inside the effect body, causing a useExhaustiveDependencies lint error. Also auto-format wire-policy.test.ts and .claude/scheduled_tasks.json to satisfy Biome's formatting rules.

Type of change

  • [ √] Bug fix
  • New feature
  • Refactor (no behavior change)
  • Documentation
  • Build / CI / tooling
  • Breaking change

Linked issue

Checklist

  • [ √] I read docs/VISION.md, docs/PRINCIPLES.md, and CLAUDE.md before starting
  • Commits are signed with DCO (git commit -s)
  • [√ ] pnpm lint && pnpm typecheck && pnpm test passes locally
  • Added/updated tests for the change
  • Added a changeset (pnpm changeset) if user-visible
  • Updated docs if behavior changed

Dependency additions (if any)

Screenshots / recordings (UI changes)

)

Signed-off-by: Jiangxy-1 <jiangxy177@gmail.com>
@github-actions github-actions Bot added area:desktop apps/desktop (Electron shell, renderer) area:providers packages/providers (pi-ai adapter, model calls) labels Apr 24, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • [Blocker] Latest commit is missing the required DCO sign-off — the repository requires Signed-off-by on every commit, and commit ae561824741eda70396d01ef990fadd6c3feb441 does not include one.
    Suggested fix:
    git commit --amend -s --no-edit
    git push --force-with-lease

Summary

Review mode: initial. No diff-attributable code defects stood out in the touched files, but the PR is not merge-ready because the latest commit is missing the required DCO sign-off. Residual test gap: I did not find an integration test covering the new synthetic wire: 'openai-responses' branch in packages/providers/src/index.ts:287.

Testing

  • Not run (automation): this workspace does not have installed test dependencies, so corepack pnpm exec vitest ... failed with Command "vitest" not found.

open-codesign Bot

Remove spurious pushToast from useEffect deps in Settings.tsx and
auto-format wire-policy.test.ts + scheduled_tasks.json to satisfy
biome format rules.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Jiangxy-1 <jiangxy177@gmail.com>
@Jiangxy-1 Jiangxy-1 force-pushed the claude/nostalgic-lamarr-c1bad6 branch from ae56182 to 0d65d89 Compare April 24, 2026 13:24
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • No diff-attributable issues identified in the added/modified lines.

Summary

  • Review mode: follow-up after new commits. No new or remaining diff-attributable defects stood out in apps/desktop/src/renderer/src/components/Settings.tsx, packages/providers/src/index.ts, packages/providers/src/wire-policy.ts, or packages/providers/src/wire-policy.test.ts. Residual gaps: docs/VISION.md and docs/PRINCIPLES.md were not found in repo/docs in this checkout, and I could not execute workspace tests in this environment.

Testing

  • Not run (automation): corepack pnpm exec vitest run packages/providers/src/index.test.ts packages/providers/src/wire-policy.test.ts failed with Command "vitest" not found.
  • Not run (automation): corepack pnpm exec tsc -p packages/providers/tsconfig.json --noEmit failed because workspace dependencies/types are not installed in this environment.

open-codesign Bot

@Sun-sunshine06 Sun-sunshine06 merged commit 7221a80 into OpenCoworkAI:main Apr 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:desktop apps/desktop (Electron shell, renderer) area:providers packages/providers (pi-ai adapter, model calls)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants