fix(lint): resolve biome check failures blocking push#224
Merged
Sun-sunshine06 merged 2 commits intoOpenCoworkAI:mainfrom Apr 24, 2026
Merged
fix(lint): resolve biome check failures blocking push#224Sun-sunshine06 merged 2 commits intoOpenCoworkAI:mainfrom
Sun-sunshine06 merged 2 commits intoOpenCoworkAI:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Findings
- [Blocker] Latest commit is missing the required DCO sign-off — the repository requires
Signed-off-byon every commit, and commitae561824741eda70396d01ef990fadd6c3feb441does not include one.
Suggested fix:git commit --amend -s --no-edit git push --force-with-lease
Summary
Review mode: initial. No diff-attributable code defects stood out in the touched files, but the PR is not merge-ready because the latest commit is missing the required DCO sign-off. Residual test gap: I did not find an integration test covering the new synthetic wire: 'openai-responses' branch in packages/providers/src/index.ts:287.
Testing
- Not run (automation): this workspace does not have installed test dependencies, so
corepack pnpm exec vitest ...failed withCommand "vitest" not found.
open-codesign Bot
Remove spurious pushToast from useEffect deps in Settings.tsx and auto-format wire-policy.test.ts + scheduled_tasks.json to satisfy biome format rules. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Jiangxy-1 <jiangxy177@gmail.com>
ae56182 to
0d65d89
Compare
Contributor
There was a problem hiding this comment.
Findings
- No diff-attributable issues identified in the added/modified lines.
Summary
- Review mode: follow-up after new commits. No new or remaining diff-attributable defects stood out in
apps/desktop/src/renderer/src/components/Settings.tsx,packages/providers/src/index.ts,packages/providers/src/wire-policy.ts, orpackages/providers/src/wire-policy.test.ts. Residual gaps:docs/VISION.mdanddocs/PRINCIPLES.mdwere not found inrepo/docsin this checkout, and I could not execute workspace tests in this environment.
Testing
- Not run (automation):
corepack pnpm exec vitest run packages/providers/src/index.test.ts packages/providers/src/wire-policy.test.tsfailed withCommand "vitest" not found. - Not run (automation):
corepack pnpm exec tsc -p packages/providers/tsconfig.json --noEmitfailed because workspace dependencies/types are not installed in this environment.
open-codesign Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove spurious
pushToastfrom auseEffectdependency array in Settings.tsx where it was listed but never used inside the effect body, causing auseExhaustiveDependencieslint error. Also auto-format wire-policy.test.ts and .claude/scheduled_tasks.json to satisfy Biome's formatting rules.Type of change
Linked issue
Checklist
docs/VISION.md,docs/PRINCIPLES.md, andCLAUDE.mdbefore startinggit commit -s)pnpm lint && pnpm typecheck && pnpm testpasses locallypnpm changeset) if user-visibleDependency additions (if any)
Screenshots / recordings (UI changes)