Skip to content

fix(desktop): explain workspace binding conflicts#295

Merged
Sun-sunshine06 merged 1 commit into
mainfrom
fix/286-workspace-conflict-guidance
May 3, 2026
Merged

fix(desktop): explain workspace binding conflicts#295
Sun-sunshine06 merged 1 commit into
mainfrom
fix/286-workspace-conflict-guidance

Conversation

@Sun-sunshine06
Copy link
Copy Markdown
Collaborator

Summary

Fixes #286.

  • Keep the one-workspace-per-design guard, but return the conflicting design name in the error.
  • Add actionable guidance so the UI toast tells users to choose another folder or change the other design's workspace first.
  • Preserve the existing boolean conflict helper while adding a conflict lookup for richer messages.

Validation

  • pnpm exec biome check apps/desktop/src/main/design-workspace.ts apps/desktop/src/main/design-workspace.test.ts .changeset/workspace-conflict-guidance.md
  • pnpm --dir apps/desktop exec vitest run src/main/design-workspace.test.ts
  • pnpm --dir apps/desktop typecheck
  • pnpm --dir apps/desktop test
  • pnpm typecheck

@github-actions github-actions Bot added docs Documentation area:desktop apps/desktop (Electron shell, renderer) labels May 3, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review mode: initial

Findings

No issues found.

Summary

  • The PR correctly addresses issue #286 by improving the workspace conflict error message to include the conflicting design name and actionable guidance.
  • Refactored checkWorkspaceConflict to use a new findWorkspaceConflict helper that returns the conflicting Design object, enabling richer error messaging without duplicating the lookup logic.
  • Updated the existing test to verify the new, more descriptive error message.
  • Added a changeset for the user-visible change.
  • Code follows project conventions: no new dependencies, no security concerns, no silent fallbacks, unchanged public API surface, Biome-compatible formatting.

Testing

Existing test passes with updated expectations. No additional test scenarios are needed for this straightforward change.

Open-CoDesign Bot

@Sun-sunshine06 Sun-sunshine06 merged commit cd71db4 into main May 3, 2026
6 checks passed
@Sun-sunshine06 Sun-sunshine06 deleted the fix/286-workspace-conflict-guidance branch May 3, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:desktop apps/desktop (Electron shell, renderer) docs Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Workspace path binding conflict prevents multiple designs from sharing workspace

1 participant