Skip to content

fix(desktop): support --no-sandbox when launched as uid 0 #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hqhq1025 merged 1 commit into from
May 23, 2026
Merged

fix(desktop): support --no-sandbox when launched as uid 0 #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions apps/desktop/scripts/dev.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,14 @@ const env = { ...process.env };
// so Electron behaves like Node. The desktop dev app must launch real Electron.
env.ELECTRON_RUN_AS_NODE = undefined;

// Electron exits fatally when launched as uid 0 unless --no-sandbox is passed.
// Containers, dev VMs, and CI runners commonly run as root; without this they
// can never `pnpm dev` at all. electron-vite reads NO_SANDBOX=1 and forwards
// --no-sandbox to the spawned Electron process (see electron-vite/dist startElectron).
if (process.getuid && process.getuid() === 0 && !env.NO_SANDBOX) {
env.NO_SANDBOX = '1';
}

const child = spawn(process.execPath, [electronViteBin, 'dev', ...process.argv.slice(2)], {
env,
stdio: ['inherit', 'inherit', 'pipe'],
Expand Down
4 changes: 4 additions & 0 deletions apps/desktop/src/main/preview-runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@ export async function runPreview(opts: RunPreviewOptions): Promise<PreviewResult
// dialogs that would otherwise stall the launch handshake.
'--no-first-run',
'--no-default-browser-check',
// Chrome's zygote refuses to start as uid 0 without this. Containers,
// dev VMs, and CI runners frequently run as root; gating to root keeps
// the production launch path unchanged on macOS/Windows/user-mode Linux.
...(process.getuid?.() === 0 ? ['--no-sandbox'] : []),
],
});
page = await browser.newPage();
Expand Down
Loading