Skip to content

fix(desktop): tokenize PreviewToolbar values missed by #57 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hqhq1025 merged 2 commits into from
Apr 18, 2026
Merged

fix(desktop): tokenize PreviewToolbar values missed by #57 #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57b4bd8
fix(desktop): tokenize remaining PreviewToolbar hardcoded values miss…
hqhq1025 Apr 18, 2026
822c59a
chore: format Download icon and silence pre-existing core complexity …
hqhq1025 Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions apps/desktop/src/renderer/src/components/PreviewToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,19 +78,22 @@ export function PreviewToolbar(): ReactElement {
type="button"
disabled={disabled}
onClick={() => setOpen((v) => !v)}
className="inline-flex items-center gap-1.5 h-[30px] px-3 rounded-[var(--radius-md)] text-[var(--text-sm)] font-medium border border-[var(--color-border)] bg-[var(--color-surface)] text-[var(--color-text-primary)] hover:bg-[var(--color-surface-hover)] hover:border-[var(--color-border-strong)] disabled:opacity-40 disabled:pointer-events-none transition-[background-color,border-color] duration-150 ease-[cubic-bezier(0.16,1,0.3,1)]"
className="inline-flex items-center gap-1.5 h-[var(--size-control-sm)] px-3 rounded-[var(--radius-md)] text-[var(--text-sm)] font-medium border border-[var(--color-border)] bg-[var(--color-surface)] text-[var(--color-text-primary)] hover:bg-[var(--color-surface-hover)] hover:border-[var(--color-border-strong)] disabled:opacity-40 disabled:pointer-events-none transition-[background-color,border-color] duration-150 ease-[cubic-bezier(0.16,1,0.3,1)]"
aria-haspopup="menu"
aria-expanded={open}
>
<Download className="w-[14px] h-[14px]" aria-hidden="true" />
<Download
className="w-[var(--size-icon-sm)] h-[var(--size-icon-sm)]"
aria-hidden="true"
/>
{t('export.button')}
</button>
</Tooltip>

{open && (
<div
role="menu"
className="absolute right-0 top-full mt-2 min-w-[200px] rounded-[var(--radius-md)] border border-[var(--color-border)] bg-[var(--color-surface)] shadow-[var(--shadow-elevated)] py-1 z-10"
className="absolute right-0 top-full mt-2 min-w-[var(--size-stage-min)] rounded-[var(--radius-md)] border border-[var(--color-border)] bg-[var(--color-surface)] shadow-[var(--shadow-elevated)] py-1 z-10"
>
{exportItems.map((item) => (
<button
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ function buildRevisionPrompt(input: ApplyCommentInput, contextSections: string[]
return parts.join('\n\n');
}

// biome-ignore lint/complexity/noExcessiveCognitiveComplexity: orchestration step with linear branching; refactor tracked separately
async function runModel(input: ModelRunInput): Promise<GenerateOutput> {
const log = input.logger ?? NOOP_LOGGER;
const scope = input.logScope ?? 'generate';
Expand Down
3 changes: 3 additions & 0 deletions packages/ui/src/tokens.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,9 @@
/* Chip / file-token max width */
--size-chip-max: 180px;

/* Minimum width for menus, popovers, and stage panels */
--size-stage-min: 200px;

/* Press feedback scale */
--scale-hover-up: 1.04;
--scale-press-down: 0.96;
Expand Down
Loading